Fix api docs display error for fluid Initializer #9786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2018 15:49
… initialize Merge branch develop
abhinavarora
reviewed
Apr 9, 2018
python/paddle/fluid/initializer.py
Outdated
| __all__ = [ | ||
| 'Constant', 'Uniform', 'Normal', 'Xavier', 'force_init_on_cpu', | ||
| 'init_on_cpu' | ||
| 'ConstantInitializer', 'UniformInitializer', 'NormalInitializer', 'XavierInitializer', 'Constant', 'Uniform', 'Normal', 'Xavier', 'force_init_on_cpu','init_on_cpu' |
There was a problem hiding this comment.
I am not sure why we need to do this? Constant == ConstantInitializer, Uniform = UniformInitializer and so on. Could you elaborate why we need this change
There was a problem hiding this comment.
#9761
The above issue mentions the display error caused by operations like Constant==ConstantInitializer, and the documents are all auto generated by gen_doc.py, which traverses items in __all__. I've asked @reyoung for suggestions and decide to solve this problem by add suffixes to alias name. e.g Constant -> ConstantInitializer and expose both of them.
added 6 commits
April 9, 2018 18:22
… initializer Merge branch develop
… initializer Merge branch develop
luotao1
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9761