Skip to content

Fix CPPLint issues in spp_op, sum_op, topk_op, transpose_op, unpool_Op and warpctc_op #9779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2018
Merged

Fix CPPLint issues in spp_op, sum_op, topk_op, transpose_op, unpool_Op and warpctc_op #9779

merged 1 commit into from
Apr 9, 2018

Conversation

abhinavarora
Copy link
Contributor

@abhinavarora abhinavarora commented Apr 9, 2018 •
edited
Loading

Fixes #9755

@abhinavarora abhinavarora self-assigned this Apr 9, 2018
@abhinavarora abhinavarora mentioned this pull request Apr 9, 2018
Closed
luotao1
luotao1 approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luotao1 luotao1 merged commit 554c917 into PaddlePaddle:develop Apr 9, 2018
@abhinavarora abhinavarora deleted the cpplint_ops_t branch April 9, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@sidgoyal78 sidgoyal78 Awaiting requested review from sidgoyal78

@kexinzhao kexinzhao Awaiting requested review from kexinzhao

Assignees

@abhinavarora abhinavarora

Labels

Code Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhinavarora @luotao1