Support testing during training by ParallelExecutor. #9738
Conversation
qingqing01
force-pushed
the
parallel_exe2
branch
from
93c8036 to
ea31b4d
Compare
| num_threads=None, | ||
| allow_op_delay=False): | ||
| allow_op_delay=False, | ||
| share_vars_from=None): |
There was a problem hiding this comment.
need comments and small examples for constructor
| main = main if main else framework.default_main_program() | ||
| scope = executor.global_scope() | ||
|
|
||
| local_scopes = share_vars_from.executor.local_scopes( |
There was a problem hiding this comment.
check share_vars_from type
| local_scopes = share_vars_from.executor.local_scopes( | ||
| ) if share_vars_from else [] | ||
|
|
||
| vars = [ |
There was a problem hiding this comment.
call it persistable_vars? Does this include all vars needed? Or maybe it includes more vars than necessary? We can leave a TODO here so that we can have the right var collection here in the future?
There was a problem hiding this comment.
Or maybe it includes more vars than necessary
Now, this case is existing. The C++ code filters the non LoDTensor.
There was a problem hiding this comment.
@panyx0718 Thanks. Could I merge this PR? So other people can use this function. Your comments can be fixed in next PR.
| local_scopes = share_vars_from.executor.local_scopes( | ||
| ) if share_vars_from else [] | ||
|
|
||
| vars = [ |
There was a problem hiding this comment.
Or maybe it includes more vars than necessary
Now, this case is existing. The C++ code filters the non LoDTensor.
qingqing01
force-pushed
the
parallel_exe2
branch
from
17788f6 to
f4caef0
Compare
qingqing01
force-pushed
the
parallel_exe2
branch
from
f4caef0 to
f522797
Compare
3 participants
Related to #9656