Skip to content

Fix for failure in LRN op when MKLDNN is not used #9528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Fix for failure in LRN op when MKLDNN is not used #9528

merged 1 commit into from
Mar 30, 2018

Conversation

tpatejko
Copy link

This PR is a fix for #9493

Plain LRN Op throws an exception when is_test attribute is set in LRN backward pass.

@tpatejko tpatejko requested a review from luotao1 March 30, 2018 08:32
luotao1
luotao1 approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have already tested on my local machine which doesn't support MKLDNN.

@luotao1 luotao1 merged commit 527e658 into PaddlePaddle:develop Mar 30, 2018
@wangkuiyi wangkuiyi added the Intel label May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

Intel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tpatejko @luotao1 @wangkuiyi