add split ids op #9370
Merged
add split ids op #9370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
typhoonzero
reviewed
Mar 26, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
Just one comment, all others LGTM
|
|
||
| const size_t shard_num = outs.size(); | ||
|
|
||
| std::vector<std::vector<T>> out_ids; |
Contributor
There was a problem hiding this comment.
Maybe can remove this temp vector and push data directly to outs[i] to reduce one for loop.
Member
Author
There was a problem hiding this comment.
The problem is that we don't know the shape of outs[i], so we cannot call mutable_data to allocate memory for it. The first loop is used to get the shape of each outs.
Contributor
|
Don't know why build android on travis-ci stucks. |
Member
Author
|
@typhoonzero Ok, I will restart the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project: #9211
fix: #9372