Add float16 support to batch norm operator #9176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Mar 21, 2018
| auto *saved_variance = ctx.Output<Tensor>("SavedVariance"); | ||
|
|
||
| // alloc memory | ||
| y->mutable_data<T>(ctx.GetPlace()); |
There was a problem hiding this comment.
why here does not use BatchNormParamType?
There was a problem hiding this comment.
Per the cudnn API, when we are using fp16 mode to run Batch norm cudnn, the data type of input x and output y will be fp16, but the other input parameters including mean and variance will still be float32 type.
So here T == float16, and BatchNormParamType<T> == float as defined in cudnn_helper.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9175
Only added and verified float16 kernel for the inference mode of cudnn batch norm kernel,
which is needed to run vgg/resnet inference.
OpTest.np_dtype_to_fluid_dtype is to change the dtype of a numpy array from float16 to uint16 so that it can correctly bind with paddle float16 in tensor_py.h.