add resnet profile #8674
Closed
add resnet profile #8674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
requested review from
reyoung,
helinwang,
qingqing01,
QiJune,
tonyyang-svail and
panyx0718
panyx0718
previously approved these changes
Mar 2, 2018
… add-resnet-profile
helinwang
reviewed
Mar 6, 2018
python/paddle/fluid/executor.py
Outdated
| @@ -240,56 +241,63 @@ def run(self, | |||
| if scope is None: | |||
| scope = global_scope() | |||
|
|
|||
| program = program.clone() | |||
| global_block = program.global_block() | |||
| program_cache_key = str(feed.keys() + fetch_list) | |||
There was a problem hiding this comment.
Should the cache key includes a hash from the program as well? Otherwise if the program changed but the input / output is the same, we end up running a wrong program.
There was a problem hiding this comment.
yes, we are thinking about adding a version number to the program, so we can check if the program has changed.
|
add the profile script to benchmark repo. dzhwinter/benchmark#84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.