Add Go_op, Channel_create, channel_close, channel_send and channel_receive ops #8593

abhinavarora · 2018-02-26T23:05:16Z

@kavyasrinet, @cs2be, @varunarora and I worked on this PR together.
Fixes: #8426, #8436, #8427 and #8428

This PR covers the following:

Create operators for channel_create, channel_send, channel_receive and channel_close.
Implement Go op.
Unit test to check an end-to-end implementation of CSP.

This PR does not:

Support CSP for training purposes.(i.e. implement back-propagation using CSP.). We will investigate this in future PRs.

We are working on creating more comprehensive unit tests to better capture the CSP model.

… go_op

…o_op

…huan_varun # Conflicts: # python/paddle/v2/fluid/__init__.py # python/paddle/v2/fluid/concurrency.py

…to go_op_thuan_varun

wangkuiyi

This is an awesome PR!

panyx0718 · 2018-02-27T01:26:02Z

python/paddle/fluid/framework.py

                 shape=None,
                 dtype=None,
                 lod_level=None,
+                 capacity=None,


We need to document in "Args" what is capacity.

Thank you for pointing this out. Updated the comments.

panyx0718 · 2018-02-27T01:31:35Z

python/paddle/fluid/framework.py

                            self.name, self.persistable, persistable))

+        if capacity is not None:
+            if is_new_var:


Does every new Var need a capacity? Is it channel specific?

Yes, capacity is specific only to a channel. I just added this information in the docstring comment also.

jacquesqiao · 2018-02-27T02:18:06Z

python/paddle/fluid/tests/notest_concurrency.py



 class TestRoutineOp(unittest.TestCase):
    def test_simple_routine(self):


seems test_concurrecy.py is not enabled now, should we enable it?

This needs more support in Python side to enable it. We will enable it soon when the test will be able to run successfully

chengduoZH · 2018-02-27T15:23:50Z

paddle/fluid/framework/concurrency_test.cc

+
+  // Create Go Op routine
+  ProgramDesc goOpProgram;
+  BlockDesc *goOpBlock = goOpProgram.MutableBlock(0);


I am curious about why you don't you get a new block from program but define goOpProgram and get the block0 of goOpProgram.

good point, i will update unit test

chengduoZH · 2018-02-27T16:03:08Z

paddle/fluid/operators/channel_recv_op.cc

+      cpu, framework::ToTypeIndex(framework::proto::VarType::BOOL));
+  platform::DeviceContextPool &pool = platform::DeviceContextPool::Instance();
+  auto &dev_ctx = *pool.Get(dev_place);
+  math::set_constant(dev_ctx, status_tensor, status);


Now that status_tensor is on CPU side and the dimention of it is {1}, why don't set status to status_tensor, but use math::set_constant?

do you mean this should work status_tensor[0] = true/false?

Thank you fixed it.

chengduoZH · 2018-02-27T16:22:43Z

paddle/fluid/operators/go_op.cc

+      framework::Executor executor(dev_place);
+      ExecuteOnThread(&executor, block, &new_scope);
+    });
+    go_thread.detach();


If the model has many Go_op, do you think it is necessary that synchronizing these Go_op?
I think maybe we need.

Yes, we have an issue open to create a mutex operator. If users communicate using channels, they do not need to use mutex (since channel already contains locks). Mutex op will be required if users accesses other shared memory.

I see, thanks.

…gram

Abhinav Arora and others added 30 commits February 12, 2018 17:32

Adding Python boilerplate code for Go op

497321a

Add very basic test case

f2a95fa

Adding the python logic for go routine

d785ca9

Fix syntax

313ffb0

Changing test to notest

a43924e

Rename Routine to Go

c97cf4a

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

39f22cf

… go_op

Combining GoGuard and Go in one class

fc2593c

Merge branch 'go_op' of https://github.com/abhinavarora/Paddle into g…

24737a6

…o_op

Modify test

8343a35

Adding fluid close channel

d0e26f7

Merge branch 'go_op' of https://github.com/abhinavarora/Paddle into g…

ccb37b9

…o_op

Fixing __init__.py for calling fluid.go()

a37a1e1

Merge branch 'go_op' of https://github.com/abhinavarora/Paddle into g…

2fb93ca

…o_op

Adding stubs for channel methods and updating test case

f5f6370

Removing import *

323a2e2

Merge branch 'go_op' of github.com:abhinavarora/Paddle into go_op

d02873b

Merge remote-tracking branch 'origin/develop' into go_op

04cb0f3

Adding imports from concurrency

47f9680

Initial commit of GO_OP (for varun)

802eb42

Merge branch 'develop' of github.com:PaddlePaddle/Paddle into go_op_t…

934352a

…huan_varun # Conflicts: # python/paddle/v2/fluid/__init__.py # python/paddle/v2/fluid/concurrency.py

Creating local scopes and go through them

3697796

Updated go op inputs persistability enforcement

d690a83

Add thread execution; compile failing though

e87aabb

Fix go op

60dd07b

Cleaned up Go op

9abc486

Fix yapf format issue

8b8d208

Readd warp ctc dir for unit tests

756af7b

Updated make_channel, channel_send, channel_recv and channel_close

031b8f4

Moved thread function to another method, update unit tests

1679a74

Abhinav Arora and others added 3 commits February 26, 2018 15:07

Merge remote-tracking branch 'origin/develop' into go_op_thuan_varun

e683e34

Update concurrency test to demonstrate a complete CSP flow

28faa86

Merge branch 'go_op_thuan_varun' of github.com:abhinavarora/Paddle in…

bbd46ca

…to go_op_thuan_varun

abhinavarora assigned abhinavarora, cs2be, varunarora and kavyasrinet Feb 26, 2018

cs2be and others added 5 commits February 26, 2018 15:11

Fix clang-format issues

2eb88f1

Fixed "Out" parameter name

886610e

Fixing merge conflict in framework.py

2308ded

Add channel ops to framework.py no_kernel_op_set

ad4590e

Seperating channel_send and channel_recv operators

83f6242

abhinavarora changed the title ~~[WIP] Add Go_op, Channel_create, channel_close, channel_send and channel_receive ops~~ Add Go_op, Channel_create, channel_close, channel_send and channel_receive ops Feb 27, 2018

abhinavarora requested review from chengduoZH, reyoung and wangkuiyi February 27, 2018 01:07

wangkuiyi previously approved these changes Feb 27, 2018

View reviewed changes

panyx0718 reviewed Feb 27, 2018

View reviewed changes

jacquesqiao reviewed Feb 27, 2018

View reviewed changes

Documenting capacity type

47462e8

abhinavarora dismissed wangkuiyi’s stale review via 47462e8 February 27, 2018 14:47

chengduoZH reviewed Feb 27, 2018

View reviewed changes

cs2be and others added 3 commits February 27, 2018 10:28

Update concurrency test to create go block as child block of main pro…

4252300

…gram

Merge remote-tracking branch 'origin/develop' into go_op_thuan_varun

6c10e95

Changing set status implementation

a3eebd9

wangkuiyi approved these changes Feb 28, 2018

View reviewed changes

abhinavarora merged commit 0d878e4 into PaddlePaddle:develop Feb 28, 2018

abhinavarora deleted the go_op_thuan_varun branch February 28, 2018 21:10



		class TestRoutineOp(unittest.TestCase):
		def test_simple_routine(self):

Add Go_op, Channel_create, channel_close, channel_send and channel_receive ops #8593

Add Go_op, Channel_create, channel_close, channel_send and channel_receive ops #8593

Uh oh!

Conversation

abhinavarora commented Feb 26, 2018 • edited by kavyasrinet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wangkuiyi left a comment

Choose a reason for hiding this comment

Uh oh!

panyx0718 Feb 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

abhinavarora commented Feb 26, 2018 •

edited by kavyasrinet

Loading

panyx0718 Feb 27, 2018 •

edited

Loading