framework.py enhancement #8471
Merged
framework.py enhancement #8471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
reviewed
Feb 21, 2018
| return True | ||
| return False | ||
|
|
||
| if inputs is not None: |
Contributor
There was a problem hiding this comment.
Is this assuming inputs is not possible to be None? If so maybe we need to remove the default None value from the argument list.
tonyyang-svail
changed the title
helinwang
previously approved these changes
Feb 22, 2018
| for attr in proto.attrs: | ||
| attr_name = attr.name | ||
| if (not attr_name in attrs) or (attrs[attr_name] is None): | ||
| if (attr_name not in attrs) or (attrs[attr_name] is None): |
Contributor
There was a problem hiding this comment.
Hard to believe Python can do the same thing with so many different ways...
Author
There was a problem hiding this comment.
From PEP8
Use is not operator rather than not ... is. While both expressions are
functionally identical, the former is more readable and preferred.
Yes:
if foo is not None:
No:
if not foo is None:
Contributor
There was a problem hiding this comment.
Thanks for the info. It's better if only one is allowed by the syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.