Skip to content

Make CTC align op support for empty output #8114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wanghaoshuang merged 4 commits into from
Feb 8, 2018
Merged

Make CTC align op support for empty output #8114

wanghaoshuang merged 4 commits into from
Feb 8, 2018

Conversation

@wanghaoshuang
Copy link
Contributor

@wanghaoshuang wanghaoshuang commented Feb 4, 2018 •
edited
Loading

Fix #8118 #8039

@wanghaoshuang wanghaoshuang changed the title Fix ctc align Make CTC align op support for empty output Feb 5, 2018
kuke
kuke reviewed Feb 5, 2018
View reviewed changes
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingqing01
Copy link
Contributor

qingqing01 commented Feb 5, 2018

Also needs to update the doc to tell the users what the empty output is.

@wanghaoshuang
Copy link
Contributor Author

wanghaoshuang commented Feb 6, 2018

Also needs to update the doc to tell the users what the empty output is.

@qingqing01 Thx. Done.

qingqing01
qingqing01 approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wanghaoshuang wanghaoshuang merged commit 6612068 into PaddlePaddle:develop Feb 8, 2018
@wanghaoshuang wanghaoshuang deleted the fix_ctc_align branch May 20, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuke kuke kuke left review comments

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wanghaoshuang @qingqing01 @kuke