Skip to content

Close buffered channel should unblock the blocked senders and receivers #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhinavarora merged 1 commit into from
Feb 4, 2018
Merged

Close buffered channel should unblock the blocked senders and receivers #8109

abhinavarora merged 1 commit into from
Feb 4, 2018

Conversation

@abhinavarora
Copy link
Contributor

@abhinavarora abhinavarora commented Feb 3, 2018

This PR adds the following:

  1. Unit Test for checking that closing a channel unblocks all blocked senders and receivers.
  2. Adds asserts in unit test for the boolean value returned by Send and Recv as per the latest PR by @chengduoZH Refine buffer channel #8098

@abhinavarora abhinavarora self-assigned this Feb 3, 2018
@abhinavarora abhinavarora mentioned this pull request Feb 3, 2018
Closed
11 tasks
chengduoZH
chengduoZH approved these changes Feb 4, 2018
View reviewed changes
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinavarora abhinavarora merged commit 1d2dd9c into PaddlePaddle:develop Feb 4, 2018
@abhinavarora abhinavarora deleted the close_test_buffered branch February 4, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chengduoZH chengduoZH chengduoZH approved these changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@kavyasrinet kavyasrinet Awaiting requested review from kavyasrinet

Assignees

@abhinavarora abhinavarora

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhinavarora @chengduoZH