Adding unit tests for checking that closing unbuffered channel closes all blocked senders and receivers #8067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all blocked senders and receivers
11 tasks
chengduoZH
reviewed
Feb 2, 2018
paddle/framework/channel_test.cc
Outdated
| }, | ||
| &thread_ended[i]); | ||
| } | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(100)); // wait 0.5 sec |
Contributor
There was a problem hiding this comment.
It seems that waiting time is 0.1 sec but not 0.5 sec.
Contributor
Author
There was a problem hiding this comment.
Thank you fixed.
| t[i] = std::thread( | ||
| [&](bool *p) { | ||
| int data; | ||
| ch->Receive(&data); |
Contributor
There was a problem hiding this comment.
There are two possibilities for the return of Receive:
- the
Channelwas closed. - the
Sendof thisChannelwas called.
I think we should separate them. When the Channel was closed, the point of data should be nullptr. Otherwise, it should be not nullptr.
Contributor
Author
There was a problem hiding this comment.
Do you mean the data pointer that is passed to Receive, that should be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.