Transpiler: fix pserver crash due to split var name check. #7837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
commented
Jan 24, 2018
Contributor
Author
There was a problem hiding this comment.
The bug happened because "emb" is matched with "embedding_1.w_0" at this line.
Contributor
There was a problem hiding this comment.
Won't the logic remain same if we do not change this line?
Contributor
Author
There was a problem hiding this comment.
Thanks! Wanted to consolidate the code.
abhinavarora
previously approved these changes
Jan 24, 2018
Contributor
abhinavarora
left a comment
abhinavarora
left a comment
There was a problem hiding this comment.
LGTM! Thank you for fixing this issue.
In notest_dist_label_semantic_roles.py, "emb" is matched with "embedding_1.w_0", but they are two irrevalent vars. Fixes: PaddlePaddle#7701
helinwang
force-pushed
the
transpiler_fix
branch
from
2de2c7b to
39b0fdc
Compare
typhoonzero
approved these changes
Jan 25, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running notest_dist_label_semantic_roles.py, "emb" is matched with
"embedding_1.w_0", but they are two irrevalent vars, causing the init op for "emb" inits "embedding_1.w_0" instead, so "emb" is not initialized.
Fixes: #7701