【Hackathon 9th No.8】Fix 0-size for as_strided grad and add bound check for as_strided #74860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
/re-run all-failed |
… accuracy_as_strided
|
/re-run all-failed |
… accuracy_as_strided
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74860 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 10
Branches ? 0
===========================================
Hits ? 10
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
DanielSun11
reviewed
Sep 2, 2025
|
/re-run all-failed |
DanielSun11
reviewed
Sep 8, 2025
Comment on lines
43
to
49
| if (input.numel() != 0) { | ||
| size = 1; | ||
| for (int i = 0; i < input.dims().size(); i++) { | ||
| size += input.strides()[i] * (input.dims()[i] - 1); | ||
| } | ||
| memory_size = size * phi::SizeOf(dtype) + input.offset(); | ||
| } |
There was a problem hiding this comment.
CheckInBoundsForMemory中 input.numel() != 0 这个判断为true的分支目前永远不会被执行到，覆盖率到不到要求。而且无法豁免coverage的ci，请优化下此处。
There was a problem hiding this comment.
Done. coverage ci 已经通过
|
/re-run all-failed |
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Sep 18, 2025
…k for as_strided (PaddlePaddle#74860) * Fix 0-size for as_strided grad and add bound check for as_strided * fix bugs * fix bugs * fix bugs * refine code * refine code * refine code * refine code to pass coverage ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
Fix 0-size for as_strided grad and add bound check for as_strided
PaddleAPITest 中都是 torch error 的例子，所以添加了 check
另外自行测试了
paddle.as_strided(Tensor([0, 32],"float16"), shape=tuple(0,4,), stride=tuple(32,1,), )这种 case，修复反向 bug修复 #74546 中暴露的 as_strided 0-size 问题