Feature/transpiler split tensor to multiple pservers #7249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
changed the title
typhoonzero
changed the title
typhoonzero
changed the title
Yancey0623
reviewed
Jan 12, 2018
| return param_grad_map | ||
|
|
||
|
|
||
| class DistributeTranspiler: |
There was a problem hiding this comment.
I'm confusing that why we need two DistributeTranspiler?
There was a problem hiding this comment.
Rename this class to SimpleDistributeTranspiler and append to https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/__init__.py#L25
… transpiler_split_tensor
helinwang
reviewed
Jan 16, 2018
| """ | ||
| We may need to split dense tensor to one or several blocks and put | ||
| them equally onto parameter server. One block is a sub-tensor | ||
| aligned by dim[0] of the tensor. |
There was a problem hiding this comment.
Is it necessary to align by dim[0]? seems sharding has nothing to do with the shape of the lod tensor. (is this actually for select row tensor?)
There was a problem hiding this comment.
Indeed, that's true, we only need to know the original shape when concat updated parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7179
TODO:
SelectedRowswill do in next PR.This PR will use a transpiler to split variable before send to multiple servers, like: