[Update] test matrix exp tol for mac m4 #72482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
tianshuo78520a
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
测试了PR，可以修复，CI通过就可以合入，感谢帮助！
https://github.com/PaddlePaddle/Paddle/actions/runs/14658799036/job/41138767989?pr=72115
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* [Update] test matrix exp tol for mac m4 * [Update] test matrix exp tol for mac m4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
修改
matrix_exp在 mac 环境下的 rtol/atol ，从'float64': 1e-15改为'float64': 1e-12。这个算子是纯 python 实现的，因此其精度基本上是由基础的底层算子决定。
当时添加这个算子的时候还没有 mac m4 ，但是应该在其他 mac 环境中测试过，是没啥问题的。
由此，#72468 (comment) 中提到的精度问题，有可能的原因：
matrix_exp添加至目前，底层的算子有改动，影响了精度，但是当时没有 m4 环境，所以当时也没有发现。这个算子涉及到的数值运算较多，对测试环境还是比较敏感的，如 win32 只能到
'float64': 1e-04~个人感觉降低精度影响不大 ～ 看看降低精度要求是否可以通过 CI 测试，研发帮忙再评估一下影响看是否可以放行 ？ ～
关联 #59715 #72468 (comment)
@cxxly @tianshuo78520a @luotao1