Generate capi pacakge #7237
Merged
Generate capi pacakge #7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Jan 5, 2018
| make DESTDIR="$install_prefix" install | ||
|
|
||
| if [[ ${WITH_MKL:-OFF} == "ON" ]]; then | ||
| find ./third_party/install -name 'libmklml_gnu.so' -exec cp {} $install_prefix/usr/local/lib \; |
| find ./third_party/install -name 'libmklml_gnu.so' -exec cp {} $install_prefix/usr/local/lib \; | ||
| find ./third_party/install -name 'libmklml_intel.so' -exec cp {} $install_prefix/usr/local/lib \; | ||
| cp -P ./third_party/install/mkldnn/lib/* $install_prefix/usr/local/lib/ | ||
| fi |
There was a problem hiding this comment.
可以仿照如下写法来代替204-206么？ @tensor-tang
Lines 89 to 90 in 5593858
| cp -P ./third_party/install/mkldnn/lib/* $install_prefix/usr/local/lib/ | ||
| fi | ||
|
|
||
| find ./third_party/install -name 'libiomp5.so' -exec cp {} $install_prefix/usr/local/lib \; |
There was a problem hiding this comment.
209行的libiomp5只在WITH_MKL=ON的时候用，应该放到上面的if判断中。
|
Could we make things simple, how about separate into 2 parts:
|
luotao1
approved these changes
Jan 5, 2018
|
The ldd result is as follows now |
Xreki
reviewed
Jan 5, 2018
| if [[ ${WITH_MKL:-OFF} == "ON" ]]; then | ||
| find ./third_party/install -name 'libmklml_gnu.so' -exec cp {} $install_prefix/usr/local/lib \; | ||
| find ./third_party/install -name 'libmklml_intel.so' -exec cp {} $install_prefix/usr/local/lib \; | ||
| cp -P ./third_party/install/mkldnn/lib/* $install_prefix/usr/local/lib/ |
There was a problem hiding this comment.
执行make install命令时，cmake中设定自动将一些third_party库拷贝到CMAKE_INSTALL_PREFIX/third_party目录下，目前会自动拷贝的库有zlib、glog、gflags、protobuf、openblas，如：
Paddle/cmake/external/glog.cmake
Lines 71 to 78 in d06bbb1
可以考虑下要不要采用这种方式。
There was a problem hiding this comment.
I think it's a better way, and maybe @tensor-tang could consider with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #7181