[Dy2St] Update no_need_buffer names if original_name no need buffer
#71476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
PR Overview
This pull request addresses a bug in the handling of buffer names during the renaming process, ensuring that both original and new names are removed from the no_need_buffer_names when they are present.
- Fixes bug where original_name was not removed from no_need_buffer_names even if it was found in fwd_map and bwd_map.
- Updates the removal logic to check for an intersection between {original_name, new_name} and no_need_buffer_names.
Reviewed Changes
| File | Description |
|---|---|
| python/paddle/jit/dy2static/pir_partial_program.py | Updated the condition to remove both original and new buffer names from the no_need_buffer_names set |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
SigureMo
changed the title
no_need_buffer names if original_name no need bufferno_need_buffer names if original_name no need buffer
gouzil
approved these changes
Mar 7, 2025
SigureMo
changed the title
no_need_buffer names if original_name no need bufferno_need_buffer names if original_name no need buffer
SigureMo
deleted the
dy2st/update-no-need-buffer-names-after-rename-values-re
branch
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
同 #71099，之前认为只有
new_name在no_need_buffer_names里需要删，因为original_name在 Program 理论上已经找不到了，但fwd_map和bwd_map是在 rename 前获取的，因此还是找得到的，这会导致original_name仍然在no_need_buffer_names，那么这个 var 仍然会被 gc