Skip to content

【custom】modify custom instruction add pd_op in setup.py #71010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xiaoguoguo626807
Copy link
Contributor

PR Category

Execute Infrastructure

PR Types

Improvements

Description

pcard-67164

修改customEngineInstruction,补充相应成员和方法
暴露pd_op 和相关interface,trait 等数据结构

Copy link

paddle-bot bot commented Feb 5, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overrall

"Input of custom engine op is not in name map"));

auto op_var = value_exec_info->GetVarByValue(op_value);
auto variable_array = op_var->Get<VariableRefArray>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomEngine op 的输入输出一定都是 VariableRefArray 么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是,输入value是vectortype 对应vector

@xiaoguoguo626807 xiaoguoguo626807 merged commit 262965d into PaddlePaddle:develop Feb 6, 2025
31 checks passed
@xiaoguoguo626807 xiaoguoguo626807 deleted the custom_part1 branch February 6, 2025 11:39
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
…#71010)

* modify custom instruction add pd_op in setup.py

* fix custom engine test

* change ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants