【Auto-Parallel】support sharding overlap in PIR #69390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
liym27
changed the title
liym27
force-pushed
the
sharding_overlap_1108
branch
2 times, most recently
from
83dd5d8 to
95d774f
Compare
liym27
force-pushed
the
sharding_overlap_1108
branch
from
95d774f to
4ded8d8
Compare
zhiqiu
previously approved these changes
Nov 18, 2024
Comment on lines
385
to
395
| tmp = paddle._C_ops.nop(opt_op.results()[0]) | ||
| tmp.get_defining_op().set_execution_stream( | ||
| AutoParallelStreamType.SHARDING_STREAM.value | ||
| ) | ||
|
|
||
| allgather_value = paddle._C_ops.all_gather( | ||
| shard_param, self._sharding_group.id, self._sharding_degree | ||
| ) | ||
| allgather_value.get_defining_op().set_execution_stream( | ||
| AutoParallelStreamType.SHARDING_STREAM.value | ||
| ) |
There was a problem hiding this comment.
shard_param and slice_param are share_var, the dependency should be constructed automatically.
There was a problem hiding this comment.
ok, we will discuss it offline.
winter-wang
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Performance Optimization
PR Types
Performance
Description
support sharding overlap in PIR.
llama7b, auto parallel static
PCard-86802
TODO：shard_param and slice_param are share_var, the dependency should be constructed automatically.