Skip to content

[Kernel] Support negative and add necessary boundary check for take_along_axis #69385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Nov 14, 2024

PR Category

User Experience

PR Types

New features

Description

Pcard-75624

  1. take_along_axis 支持负数索引
  2. 在 kernel 中添加边界检查,移除 python 中的边界检查(减少不必要的判断)
  3. 更新对应单测,所有单测的indices范围从手动设置的非负数改为随机整数

Copy link

paddle-bot bot commented Nov 14, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Paddle_enforce

@HydrogenSulfate HydrogenSulfate merged commit 77ab9e8 into PaddlePaddle:develop Nov 14, 2024
27 of 28 checks passed
@HydrogenSulfate HydrogenSulfate deleted the support_negative_for_take_along_axis branch November 14, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants