[SOT][3.13] add LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
#69196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LOAD_FAST` and add skip tests files
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 6, 2024
| self.fused_load_store(instr) | ||
|
|
||
| def STORE_FAST_LOAD_FAST(self, instr: Instruction): | ||
| self.fused_load_store(instr) |
There was a problem hiding this comment.
直接在预处理字节码的时候拆一下吧
def expand_super_instrs(instructions: list[Instruction]) -> list[Instruction]:
expanded_instrs = []
def replace_jump_target(instrs, old_target, new_target):
for instr in instrs:
if instr.jump_to == old_target:
instr.jump_to = new_target
for instr in instructions:
if instr.opname == "LOAD_FAST_LOAD_FAST":
instr1 = Instruction(
opcode=dis.opmap["LOAD_FAST"],
opname="LOAD_FAST",
arg=instr.arg >> 4,
argval=instr.argval[0],
offset=instr.offset,
starts_line=instr.starts_line,
is_jump_target=instr.is_jump_target,
jump_to=instr.jump_to,
is_generated=True,
)
instr2 = Instruction(
opcode=dis.opmap["LOAD_FAST"],
opname="LOAD_FAST",
arg=instr.arg & 15,
argval=instr.argval[1],
offset=instr.offset,
starts_line=instr.starts_line,
is_jump_target=instr.is_jump_target,
jump_to=instr.jump_to,
is_generated=True,
)
replace_jump_target(instructions, instr, instr1)
expanded_instrs.append(instr1)
expanded_instrs.append(instr2)
else:
expanded_instrs.append(instr)
return expanded_instrs
SigureMo
changed the title
LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests filesLOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
SigureMo
reviewed
Nov 6, 2024
| @@ -91,6 +91,98 @@ def convert_instruction(instr: dis.Instruction) -> Instruction: | |||
| ) | |||
|
|
|||
|
|
|||
| def expand_super_instrs(instructions: list[Instruction]) -> list[Instruction]: | |||
SigureMo
reviewed
Nov 6, 2024
| if instr.jump_to == old_target: | ||
| instr.jump_to = new_target | ||
|
|
||
| def _gen_instr(instr, opname, argval, arg): |
There was a problem hiding this comment.
Suggested change
| def _gen_instr(instr, opname, argval, arg): | |
| def copy_instruction(instr, opname, argval, arg): |
Comment on lines
114
to
123
| if instr.opname == "LOAD_FAST_LOAD_FAST": | ||
| instr1 = _gen_instr( | ||
| instr, "LOAD_FAST", instr.argval[0], instr.arg >> 4 | ||
| ) | ||
| instr2 = _gen_instr( | ||
| instr, "LOAD_FAST", instr.argval[1], instr.arg & 15 | ||
| ) | ||
| replace_jump_target(instructions, instr, instr1) | ||
| expanded_instrs.append(instr1) | ||
| expanded_instrs.append(instr2) |
| arg=arg, | ||
| argval=argval, | ||
| is_jump_target=instr.is_jump_target, | ||
| is_generated=True, |
There was a problem hiding this comment.
Suggested change
| is_generated=True, | |
| is_generated=False, |
False 吧？
| opname=opname, | ||
| arg=arg, | ||
| argval=argval, | ||
| is_jump_target=instr.is_jump_target, |
There was a problem hiding this comment.
第一个是 instr.is_jump_target，第二个是 False，不能直接 copy
gouzil
changed the title
LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests filesLOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
gouzil
changed the title
LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests filesLOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
LOAD_FAST_LOAD_FAST、STORE_FAST_STORE_FAST、STORE_FAST_LOAD_FAST三个字节码