-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOT][3.13] eval_frame
support python 3.13
#69126
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ef310ad
sot support py 3.13
gouzil 53057d8
Merge branch 'develop' of github.com:gouzil/Paddle into sot/support_p…
gouzil 4d42036
support eval_frame
gouzil 15c6cce
fix clean error
gouzil 8de0f77
rollback and split name
gouzil 0a5eb61
use `PyFrame_GET_CODE`
SigureMo c20b37d
wrap `()` to avoid `!PY_3_13_PLUS` take no effect
SigureMo a158625
clean `Internal_PyFrame_FastToLocalsWithError` in python3.13
gouzil e3130db
fix: debug assert
gouzil ca0524a
duplicate `return NULL` to avoid write `!PY_3_13_PLUS` twice
SigureMo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注意 3.13 是将
PyFrame_FastToLocalsWithError
变为无操作,因为这个接口会被弃用并删除,而我们这里在 3.11+ 以来对齐的是_PyFrame_FastToLocalsWithError
,这个接口在 python/cpython#115153 被直接删除,但并不是不需要了,而是使用了替代方案,主要是_PyFrame_GetLocals
可以参考 python/cpython#115153 中的替换
_PyFrame_FastToLocalsWithError
的使用方式,我们可以也直接替换下,3.13 我们就不用编Internal_PyFrame_FastToLocalsWithError
这个接口了debug 版本的报错可能是因为这个原因,可以试下
改动动机可以看看 PEP 667
非 debug 版本 Linux 下验证通过,这个问题解决后感觉就可以合入了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在没有使用
GetLocals
基本 case 能过,但后续需要注意下是否有问题