Skip to content

[Auto Parallel] fix fuse_qkv_ffn pass+vpp bug #69103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

Wennie396
Copy link
Contributor

@Wennie396 Wennie396 commented Nov 1, 2024

PR Category

Auto Parallel

PR Types

Bug fixes

Description

Pcard-76459
修复分布式场景下vpp和fuse_qkv_ffn pass同时开报错的bug,

  • fuse_qkv_ffn pass构建fuse后的op时,没有设置完op的attr,导致后续vpp切图的时候缺少struct_name属性
  • fuse_qkv_ffn pass位置在一进入_parallel_pir,对权重进行fuse后直接添加到global_scope里面并且在concrete_program中删去fuse前的param而没有加入fuse后的param,后续在initialize的时候vpp会对所有param根据chunk id进行reshard,出现fuse后的param不在scope里面的情况,导致后续部分fuse后的param无法添加到kwarg里面,从而出现shape的报错

Copy link

paddle-bot bot commented Nov 1, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhangbo9674
zhangbo9674 previously approved these changes Nov 5, 2024
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhiqiu zhiqiu merged commit a8a21a2 into PaddlePaddle:develop Nov 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants