Skip to content

[XPU] support argmax int64 & update xhpc date #68894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2024
Merged

[XPU] support argmax int64 & update xhpc date #68894

merged 2 commits into from
Oct 25, 2024

Conversation

skywalker2012
Copy link
Contributor

PR Category

Custom Device

PR Types

Others

Description

Support argmax int64

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Oct 23, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the XPU label Oct 23, 2024
@skywalker2012 skywalker2012 changed the title [XPU] Support argmax int64 [XPU] support argmax int64, update xhpc date Oct 23, 2024
@skywalker2012 skywalker2012 changed the title [XPU] support argmax int64, update xhpc date [XPU] support argmax int64 & update xhpc date Oct 23, 2024
cqulilujia
cqulilujia approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@cqulilujia cqulilujia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for updating xhpc date

lj970926
lj970926 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@lj970926 lj970926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RuohengMa
RuohengMa approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@RuohengMa RuohengMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04
Copy link
Contributor

houj04 commented Oct 25, 2024

如沟通，argmax在XHPC里面的实现，不管是int32类型还是int64类型，在极端输入的情况下可能有问题，需要后续修复。

@houj04 houj04 merged commit dd05525 into PaddlePaddle:develop Oct 25, 2024
27 checks passed
@skywalker2012
Copy link
Contributor Author

如沟通，argmax在XHPC里面的实现，不管是int32类型还是int64类型，在极端输入的情况下可能有问题，需要后续修复。

好的

@skywalker2012 skywalker2012 deleted the argmax_int64 branch October 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houj04 houj04 houj04 approved these changes

+3 more reviewers

@cqulilujia cqulilujia cqulilujia approved these changes

@lj970926 lj970926 lj970926 approved these changes

@RuohengMa RuohengMa RuohengMa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
XPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skywalker2012 @houj04 @cqulilujia @lj970926 @RuohengMa