Skip to content

[Auto Parallel] fix hang caused by different process group initialization order #68847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

deepllz
Copy link
Contributor

@deepllz deepllz commented Oct 21, 2024

PR Category

Auto Parallel

PR Types

Bug fixes

Description

修复由于通信组创建顺序不同导致的hang的问题。此问题首次出现在调试allgather moe动转静测试中,具体原因如下:
目前动转静通信组的建立是在静半reshard模块中,例如:nd_mesh_reshard_func.py,创建通信组之后所有进程都要同步一次,用以避免其他的问题。所以要求全部rank创建通信组的顺序必须严格一致,否则可能导致hang。例如有4个进程[0, 1, 2, 3],有的进程创建了[0, 2]通信组,有的进程没有,就会导致hang,moe场景恰好触发了这个case。
Pcard-73145

Copy link

paddle-bot bot commented Oct 21, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@deepllz deepllz changed the title [Auto Parallel] fix hang caused by different process group initializa… [Auto Parallel] fix hang caused by different process group initialization order Oct 21, 2024
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 308c61d into PaddlePaddle:develop Oct 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants