[Paddle Tensorrt] add pd_op.assign,pd_op.assign_value_,pd_op.assign_out converter #68775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| def setUp(self): | ||
| self.python_api = paddle.assign | ||
| self.api_args = { | ||
| "x": np.array([[2.5, 2.5], [2.5, 2.5], [2.5, 2.5]], dtype='float32') |
There was a problem hiding this comment.
converter里写了4种数据类型, 单测应该覆盖全面
| dtype = np.bool | ||
|
|
||
| constant_layer = network.add_constant( | ||
| shape, np.array(values, dtype=np.float32) |
There was a problem hiding this comment.
为啥固定死数据类型是float32?
| def setUp(self): | ||
| self.python_api = paddle.split | ||
| self.api_args = { | ||
| "x": np.random.randn(1, 2).astype(np.float32), |
There was a problem hiding this comment.
同样的, 这个单测似乎过于简单, 应该考虑到更多的case, 例如num_or_sections=1或者等于shape的值会是什么结果?
There was a problem hiding this comment.
前面都测过了，这个是补充的有bug场景的组网
| return identity_layer.get_output(0) | ||
|
|
||
|
|
||
| @converter_registry.register("pd_op.assign_value_", trt_version="8.x") |
There was a problem hiding this comment.
单测似乎没有测试pd_op.assign_value_
There was a problem hiding this comment.
TestAssignValueFloat32TRTPattern这个是
XieYunshen
approved these changes
Oct 22, 2024
vivienfanghuagood
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
New features
Description
card-71500
添加了pd_op.assign,pd_op.assign_value_,pd_op.assign_out converter,以及修复了pd_op.split_with_num的bug