[AutoParallel][PIR] Adjust dist2dense pass for kwargs-type inputs #68413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndSonder
changed the title
AndSonder
changed the title
JZ-LIANG
reviewed
Sep 25, 2024
| @@ -73,6 +73,14 @@ void ProcessDistBlock(pir::Block* block) { | |||
| auto result = op_item->result(i); | |||
| result.set_type(CastToLocalType(result.type())); | |||
| } | |||
|
|
|||
| for (size_t i = 0; i < op_item->num_operands(); ++i) { | |||
There was a problem hiding this comment.
为什么用 operands 判断，不用 result 判断
There was a problem hiding this comment.
之前用 result 的逻辑没有动，grad merge 场景下有些 var 是从 startup_program 拿过来的，属于 kwargs, 这一类的 value 在 dist_program 里面就没有 op 把它作为输出，所有 dist2dence 的时候就会给这些 value 漏掉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Bug fixes
Description
Fix the dist2dense pass when the input needs to be cast to dense, as shown below.
The kwargs-type inputs will cause error when run
pm.run(ir_program)Pcard-76459