Skip to content

fix AMP cast bug when query==key in fuse_gate_attention #68007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix AMP cast bug when query==key in fuse_gate_attention #68007

merged 1 commit into from
Sep 6, 2024

Conversation

GuoxiaWang
Copy link
Contributor

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

Pcard-70459

In fuse_gate_attention Op, it requires query==key when merge_qkv=True. But it auto casts query and key tensor to new_query and new_key, thus assert query==key fail.

@wanghuancoder wanghuancoder merged commit 5c8084f into PaddlePaddle:develop Sep 6, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuoxiaWang @wanghuancoder