[CINN]【Infer Symbolic Shape 】Add pyramid_hash op #67951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Title和Description描述太简陋，Description中需要加上Pcard-67164 |
gongshaotian
reviewed
Sep 5, 2024
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc
Outdated
Show resolved
Hide resolved
gongshaotian
reviewed
Sep 5, 2024
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc
Outdated
Show resolved
Hide resolved
gongshaotian
reviewed
Sep 5, 2024
| // Set the output shapes | ||
| std::vector<symbol::DimExpr> out_shape = {infer_context->GetNextSymName(), | ||
| symbol::DimExpr(num_emb)}; | ||
| std::vector<symbol::DimExpr> drop_pos = {infer_context->GetNextSymName(), 1}; |
There was a problem hiding this comment.
再看一下这个能算出来吗，看起来bottom就是x？
There was a problem hiding this comment.
在kernel中，out就是top_lod, drop_pos就是drop_pos_lod。这两个符号在推导过程中用的类似的逻辑。out采用新符号，drop——pos的操作也应该采用新符号。
crazyxiaoxi
changed the title
| symbol::ShapeOrDataDimExprs{symbol::TensorShapeOrDataDimExprs(drop_pos)}); | ||
| infer_context->SetShapeOrDataForValue( | ||
| op->result(2), | ||
| symbol::ShapeOrDataDimExprs{symbol::TensorShapeOrDataDimExprs(x_shape)}); |
gongshaotian
approved these changes
Sep 18, 2024
luotao1
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
improvements
Description
添加pyramid_hash 算子符号推导接口
本算子有单测，但只含unnitest
Pcard-67164