[Dy2St] Fix jupyter error message display errors #67893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Sep 3, 2024
python/paddle/jit/dy2static/error.py
Outdated
| @@ -120,7 +120,9 @@ def __init__(self, location, function_name): | |||
| hint_msg = '~' * len(self.source_code[-1]) + ' <--- HERE' | |||
| self.source_code.append(hint_msg) | |||
| blank_count.append(blank_count[-1]) | |||
| linecache.clearcache() | |||
| # Note: It is not possible to modify the contents of the file in the meantime, so there is no need to clear the cache | |||
There was a problem hiding this comment.
Suggested change
| # Note: It is not possible to modify the contents of the file in the meantime, so there is no need to clear the cache | |
| # NOTE(gouzil): It is not possible to modify the contents of the file in the meantime, so there is no need to clear the cache |
这个 note，说明下 jupyter 下的问题吧，在 note 里说明不能用 linecache.clearcache 即可，下面的注释行删掉
|
@megemini 这个 PR 解决了之前说的 https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/guides/paddle_v3_features/sot_cn.html#id2 报错不一样的问题，本质上是 ipython 的问题，jupyter 同样可以复现 @gouzil PR 描述应该写清楚些，不然其他人看不懂，后面其他人翻看 PR 也无法了解当初的动机和具体解决的问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
修复在 jupyter 下报错异常的问题