[SOT] Dispatcher support ListVariable extend DictVariable and DictVariable
#67823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Sep 2, 2024
| @@ -1072,15 +1074,12 @@ def build_seq_unpack(self, instr: Instruction): | |||
| ) | |||
| ) | |||
|
|
|||
| @call_break_graph_decorator(push_n=1) | |||
There was a problem hiding this comment.
想看看还有没有别的地方会 BreakGraphError 挂在这里
| if not isinstance(item, (TupleVariable, ListVariable)): | ||
| raise BreakGraphError(f"{type(item)} not support unpack") | ||
| retval.extend(item.get_wrapped_items()) | ||
| assert isinstance( |
There was a problem hiding this comment.
这里是怎么保证没有其他 type 进来的？dispatch 没添加还是？
There was a problem hiding this comment.
BUILD_* 字节码和 dispatch 都会限制
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
支持
list.extend(list, range | list | dict)相关pr:
BreakGraphErrorwhen extendListVariablewithRangeVariable#67591