[CINN]optimze cinn slice infer symbolic #67803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
phlrain
changed the title
zyfncg
reviewed
Aug 30, 2024
| slice_dims.at(axis) = ends.at(i) - starts.at(i); | ||
| int64_t axis = axes[i]; | ||
| slice_dims[axis] = ends[i] - starts[i]; | ||
| if (!in_dims[axis].isa<int64_t>() || !ends[i].isa<int64_t>()) { |
There was a problem hiding this comment.
如果都是int，在CheckAndUpdateSliceAttrs 已经把ends[i] 更新为 in_dim[axes]了
There was a problem hiding this comment.
这里如果都为int类型，是不也需要取个最小值？
这种情况放在CheckAndUpdateSliceAttrs()中处理了
There was a problem hiding this comment.
那这里的end取最小值是不也最好统一放在CheckAndUpdateSliceAttrs里面？
zyfncg
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
pcard-76996
优化slice的 符号推导逻辑
对于 a[:200], a[:S0] 这种写法，需要考虑 dim 和 end 存在的情况，有符号的时候，要取最小值
TODO：