[XPU] add depthwise_conv2d backward unit test #67777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
houj04
reviewed
Aug 29, 2024
| @@ -130,6 +131,21 @@ def init_paddings(self): | |||
| self.pad = [0, 1, 0, 2] | |||
| self.padding_algorithm = "EXPLICIT" | |||
|
|
|||
| def test_check_grad_no_input(self): | |||
There was a problem hiding this comment.
这些check_grad是不是应该加在基类里面呢？如果加在子类里面，为啥只加了这一个子类，这样的话其它的子类感觉还是不会跑反向的吧。
There was a problem hiding this comment.
是可以加到基类里。
但这里depthwise_conv2d有两个测试类（用_v2区分），对比了一下其实区别不大，而且每个测试类里不同测试子类的区别在于input_size。为了节省测试时间和代码简化，只选择了一种测试子类添加反向。
There was a problem hiding this comment.
本来要测试的，就是在不同形状下面的梯度都能算对才行呀。其它算子的测试case也是，不同形状下面都要能跑过才行。
这个修改可以先合，后续再改一把吧？
houj04
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Improvements
Description
add depthwise_conv2d backward unit test