support shard master weight in stage1. #67748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
JZ-LIANG
reviewed
Aug 28, 2024
| pir.set_insertion_point_after( | ||
| src_value.get_defining_op() | ||
| ) | ||
| reshard_var = paddle._C_ops.reshard_v2( |
There was a problem hiding this comment.
为啥需要 reshard 改 shape，而不是直接修改 type？
There was a problem hiding this comment.
为了更通用化。之前场景中，一般都是对fullOp的输出进行切分，直接改shape就可以。但是在amp场景下，master_weight是cast算子的输出，直接改shape从逻辑上来说，是不正确的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
New features
Description
support shard master weight in stage1.
Other
Pcard-67164