【Infer Symbolic Shape No.15】[BUAA] Add chunk_eval op #67734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
PIR 测试问题似乎不是我改的部分。 |
什么意思，pir的流水线不是过了吗 |
|
补充描述下单测状态 |
| const symbol::ShapeOrDataDimExprs &label_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(1)); | ||
|
|
||
| PADDLE_ENFORCE_EQ( |
There was a problem hiding this comment.
这个部分应该先用enforce判断两个shape的size相等，然后写个循环，给两个shape()中的每个dim都添加个equal约束
| const symbol::ShapeOrDataDimExprs &inference_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)); | ||
| const symbol::ShapeOrDataDimExprs &label_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(1)); |
There was a problem hiding this comment.
没有区分清楚 shape_or_data和 shape的概念，这里用shape后缀命名的话直接label_shape =
infer_context->GetShapeOrDataForValue(op->operand_source(1)).shape();
| bool ChunkEvalOpInferSymbolicShape( | ||
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { | ||
| const symbol::ShapeOrDataDimExprs &inference_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)); |
|
|
||
| PADDLE_ENFORCE_EQ((inference_shape.shape().size() == 3 && | ||
| inference_shape.shape()[2] == symbol::DimExpr(1)) || | ||
| inference_shape.shape().size() == 2, |
There was a problem hiding this comment.
Enforce里面关于dim的约束放到后面吧，这里只对两个size做约束。
后面补充个分支：
if( inference_shape.shape().size() == 3){
Addequalcstr()
}
|
|
||
| if (op->operand_source(2)) { | ||
| const symbol::ShapeOrDataDimExprs &seq_length_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(2)); |
已补充 |
luotao1
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
添加 chunk_eval 算子符号推导接口。