fix numpy2.1 bug when python >=3.10 #67700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
risemeup1
force-pushed
the
copy_name_analysisi.h_to_whl
branch
from
a8e4835 to
82a4f42
Compare
risemeup1
changed the title
jzhang533
previously approved these changes
Aug 28, 2024
There was a problem hiding this comment.
this will fix #67602 .
but probably more work are needed for : https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword
risemeup1
force-pushed
the
copy_name_analysisi.h_to_whl
branch
from
82a4f42 to
e5a7ebe
Compare
|
LGTM |
SigureMo
previously approved these changes
Aug 29, 2024
SigureMo
approved these changes
Aug 29, 2024
jzhang533
pushed a commit
to jzhang533/Paddle
that referenced
this pull request
Aug 30, 2024
* fix * fix * fix * fix * fix codestyle --------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Others
Description
Fix the bug in PaddlePaddle under Python 3.10 and NumPy 2.1.
For any
__array__method on a non-NumPy array-like object, dtype=None and copy=None keywords must be added to the signature - this will work with older NumPy versions as well (although older numpy versions will never pass in copy keyword). If the keywords are added to the__array__signature, then for:copy=True and any dtype value always return a new copy,
copy=None create a copy if required (for example by dtype),
copy=False a copy must never be made. If a copy is needed to return a numpy array or satisfy dtype, then raise an exception (ValueError).
Restricting numpy to version 1.21 or above is to fix the bug of not finding the ‘NDArray’ attribute when using the
numpy.typingmodule.To do：
Modify the logic in TensorToPyArray(self) according to the dtype and copy parameters.
pcard-67164