[PHI kernels] add eye op for XPU #67637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
cqulilujia
reviewed
Sep 2, 2024
| 'num_rows': self.n, | ||
| 'num_columns': self.m, | ||
| } | ||
| result = np.eye(self.n, self.m, dtype=self.dtype) |
XiaociZhang
reviewed
Sep 3, 2024
| self.n = 1000 | ||
| self.m = 100 | ||
|
|
||
| class TestXPUEyeOp2(TestXPUEyeOp): |
There was a problem hiding this comment.
再多加几个test，我记得之前有要求每个kernel至少五个
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
QingshuChen
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Others
Description
add eye op for XPU