Skip to content

[buaa]【Infer Symbolic Shape BUAA No.184】Add conv3d_transpose & conv2d_transpose & conv2d_transpose_bias op #67635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 18, 2024
Merged

[buaa]【Infer Symbolic Shape BUAA No.184】Add conv3d_transpose & conv2d_transpose & conv2d_transpose_bias op #67635

merged 14 commits into from
Oct 18, 2024

Conversation

crazyxiaoxi
Copy link
Contributor

@crazyxiaoxi crazyxiaoxi commented Aug 22, 2024 •
edited
Loading

PR Category

CINN

PR Types

improvements

Description

添加 conv3d_transpose & conv2d_transpose & conv2d_transpose_bias算子符号推导接口
全部都有对应单测，Optest且check打开，本地已经测试通过
Pcard-67164

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 22, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 labels Aug 22, 2024
@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 31, 2024

Sorry to inform you that 666e403's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@crazyxiaoxi crazyxiaoxi changed the title [buaa]【Infer Symbolic Shape BUAA No.184】Add conv3d_transpose op [buaa]【Infer Symbolic Shape BUAA No.184】Add conv3d_transpose & conv2d_transpose & conv2d_transpose_bias op Sep 14, 2024
@gongshaotian
Copy link
Contributor

gongshaotian commented Sep 20, 2024 •
edited
Loading

conv2d_transpose_bias对应单测：test/mkldnn/test_conv2d_transpose_mkldnn_op.py
conv2d_transpose对应单测：test/legacy_test/test_conv2d_transpose_op.py
conv3d_transpose对应单测：test/legacy_test/test_conv3d_transpose_op.py

test_conv3d_transpose_op coverage 流水线未执行，test_conv2d_transpose_op会产生新符号手动关闭，test_conv2d_transpose_mkldnn_op 未开启check_pir flag。

@crazyxiaoxi
Copy link
Contributor Author

conv2d_transpose_bias对应单测：test/mkldnn/test_conv2d_transpose_mkldnn_op.py conv2d_transpose对应单测：test/legacy_test/test_conv2d_transpose_op.py conv3d_transpose对应单测：test/legacy_test/test_conv3d_transpose_op.py

test_conv3d_transpose_op coverage 流水线未执行，test_conv2d_transpose_op会产生新符号手动关闭，test_conv2d_transpose_mkldnn_op 未开启check_pir flag。

conv3d_transpose还有单测： /test/legacy_test/test_conv3d_transpose_part2_op.py

@gongshaotian
Copy link
Contributor

conv2d_transpose_bias对应单测：test/mkldnn/test_conv2d_transpose_mkldnn_op.py conv2d_transpose对应单测：test/legacy_test/test_conv2d_transpose_op.py conv3d_transpose对应单测：test/legacy_test/test_conv3d_transpose_op.py
test_conv3d_transpose_op coverage 流水线未执行，test_conv2d_transpose_op会产生新符号手动关闭，test_conv2d_transpose_mkldnn_op 未开启check_pir flag。

conv3d_transpose还有单测： /test/legacy_test/test_conv3d_transpose_part2_op.py

这个coverage 流水线应该也未执行

@crazyxiaoxi
Copy link
Contributor Author

截屏2024-09-23 14 21 57 截屏2024-09-23 14 23 30 截屏2024-09-23 14 25 09 截屏2024-09-23 14 26 15 本地测试

gongshaotian
gongshaotian reviewed Sep 24, 2024
View reviewed changes
test/legacy_test/test_conv3d_transpose_op.py Outdated
Comment on lines 310 to 312
self.check_output_with_place(place, atol=1e-5)
self.check_output_with_place(place, atol=1e-5, check_pir=True)
else:
self.check_output()
self.check_output(check_pir=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里先不要打开，明天本地再测试下

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 28, 2024

Sorry to inform you that e0222df's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@crazyxiaoxi
Copy link
Contributor Author

截屏2024-10-16 16 22 37 新增的单测也已经通过

Hongqing-work
Hongqing-work reviewed Oct 17, 2024
View reviewed changes
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc Outdated
"The Attr(output_padding) and Attr(stride) of Op(conv_transpose) "
"should be the same."));

const bool channel_last = (data_format != "NHWC");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channel_last就是NHWC吧

gongshaotian
gongshaotian reviewed Oct 17, 2024
View reviewed changes
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc Outdated
Comment on lines 520 to 522
const bool channel_last = (data_format != "NHWC");
const symbol::DimExpr C =
(channel_last ? x_shape[1] : x_shape[x_shape.size() - 1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改一下 channnel_last 变量命名

zyfncg
zyfncg reviewed Oct 17, 2024
View reviewed changes
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/binary_infer_sym.cc Outdated
bool Conv3dOpInferSymbolicShape(pir::Operation *op,
pir::InferSymbolicShapeContext *infer_context) {
return Conv2dOpInferSymbolicShape(op, infer_context);
}

bool convtransposefunction(pir::Operation *op,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

函数命名用单词首字母大写的形式

@crazyxiaoxi
fix comment:
97e2c12 
fix comment

fix comment

fix comment
@luotao1 luotao1 merged commit cc9f28e into PaddlePaddle:develop Oct 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg left review comments

@Hongqing-work Hongqing-work Hongqing-work left review comments

@luotao1 luotao1 luotao1 approved these changes

@gongshaotian gongshaotian gongshaotian approved these changes

Assignees

@luotao1 luotao1

@gongshaotian gongshaotian

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazyxiaoxi @gongshaotian @luotao1 @zyfncg @Hongqing-work