-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN]Apply input dynamic dim specification #67628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CINN]Apply input dynamic dim specification #67628
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
2355104
to
28678b1
Compare
/* | ||
* CINN related FLAG | ||
* Name: FLAGS_cinn_specify_input_dynamic_dim | ||
* Since Version: develop | ||
* Value Range: bool, default=false | ||
* Example: FLAGS_cinn_specify_input_dynamic_dim=true will use file set by | ||
* FLAGS_cinn_input_dynamic_dim_spec_file to specify input dynamic dimention. | ||
*/ | ||
PHI_DEFINE_EXPORTED_bool(cinn_specify_input_dynamic_dim, | ||
false, | ||
"Whether to specify input dynamic dimention."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个flag是不可以不用添加?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之后考虑给path指定默认值,所以这里需要一个直接表明是否开启的开关
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for flags
/* | ||
* CINN related FLAG | ||
* Name: FLAGS_cinn_input_dynamic_dim_spec_file | ||
* Since Version: develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Since Version: develop | |
* Since Version: 3.0 beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到,下一个PR顺带修改
PR Category
CINN
PR Types
New features
Description
Pcard-67164
This PR support input dynamic dim specification.
More information about this can be found in PR67384
This json format example: