Skip to content

[PIR save/load]Fix pir_verison #67563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 22, 2024
Merged

[PIR save/load]Fix pir_verison #67563

merged 5 commits into from
Aug 22, 2024

Conversation

changeyoung98
Copy link
Contributor

@changeyoung98 changeyoung98 commented Aug 20, 2024 •
edited
Loading

PR Category

Execute Infrastructure

PR Types

Not User Facing

Description

pcard-67164
Fix pir_version bug:

  • if pir_version is <0, get_pir_version from function
  • else, use the version from user.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 20, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhangbo9674
zhangbo9674 previously approved these changes Aug 20, 2024
View reviewed changes
xiaoguoguo626807
xiaoguoguo626807 reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个getpirversion() 可以外部调用吗，这个是保证单测传非0的就用户传递的处理了？感觉不是很对呀，应该有个默认为0的设置吧

zhiqiu
zhiqiu approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for target_path_lists

@changeyoung98 changeyoung98 merged commit 32570b7 into PaddlePaddle:develop Aug 22, 2024
28 checks passed
@changeyoung98 changeyoung98 deleted the czy-version branch August 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@changeyoung98 @zhiqiu @zhangbo9674 @xiaoguoguo626807