Skip to content

[Typing][C-76] Add type annotations for python/paddle/incubate/nn/functional/fused_rotary_position_embedding.py #67556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2024
Merged

[Typing][C-76] Add type annotations for python/paddle/incubate/nn/functional/fused_rotary_position_embedding.py #67556

merged 2 commits into from
Aug 21, 2024

Conversation

haoyu2022
Copy link
Contributor

@haoyu2022 haoyu2022 commented Aug 19, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Improvements

Description

类型标注：

  • python/paddle/incubate/nn/functional/fused_rotary_position_embedding.py

Related links

@SigureMo @megemini

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@haoyu2022 haoyu2022 changed the title update fused_rotary_position_embedding.py [Typing][C-76] Add type annotations for python/paddle/incubate/nn/functional/fused_rotary_position_embedding.py Aug 19, 2024
@megemini megemini mentioned this pull request Aug 19, 2024
Closed
@paddle-bot paddle-bot bot added the contributor External developers label Aug 19, 2024
@haoyu2022 @megemini
Update python/paddle/incubate/nn/functional/fused_rotary_position_emb…
b1074e7 
…edding.py

Co-authored-by: megemini <megemini@outlook.com>
megemini
megemini approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 21, 2024
@luotao1 luotao1 merged commit 4e036f9 into PaddlePaddle:develop Aug 21, 2024
27 of 28 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Aug 21, 2024

hi, @haoyu2022

  • 非常感谢你对飞桨的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

@haoyu2022 haoyu2022 mentioned this pull request Aug 23, 2024
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

+1 more reviewer

@megemini megemini megemini approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haoyu2022 @luotao1 @megemini @SigureMo