[CINN]add matmul grad fuse pattern #67466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
previously approved these changes
Aug 15, 2024
phlrain
changed the title
… add_matmul_grad_fuse_pattern
|
Sorry to inform you that 7fd453c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… add_matmul_grad_fuse_pattern
zyfncg
reviewed
Sep 6, 2024
Comment on lines
+138
to
+157
| bool have_sum_op = false; | ||
| pir::Value sum_output; | ||
| pir::Value sum_input; | ||
| for (auto user_it = dout.use_begin(); user_it != dout.use_end(); | ||
| ++user_it) { | ||
| if (!user_it->owner()) { | ||
| continue; | ||
| } | ||
| if (auto sum_op = user_it->owner()->dyn_cast<paddle::dialect::SumOp>()) { | ||
| have_sum_op = true; | ||
| sum_output = sum_op->result(0); | ||
| sum_input = sum_op->operand_source(0); | ||
| rewriter.SetInsertionPointAfter(sum_op); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!have_sum_op) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
这个sum op 是计算linear中bias的grad的，对应的是组合算子拆解前的 add_grad的算子，add_grad 被拆成了 assign op + sum op
zyfncg
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
pcard-76996
优化matmul grad的逻辑，适配编译器场景