Skip to content

【pir】modify paddlMix model of wrong opverify (masked_multihead_attention_) #67339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

xiaoguoguo626807
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 commented Aug 12, 2024

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

pcard-67164
api 生成的时候,会根据inplace 进行分析,如果输出是inplace的,则他的optional 特性是和对应的inplace 输入相同的,而 op verify 的生成没有做这个分析,因此verify 中没有感知到这是个optional 的输出。

此pr 修复op verify 生成中对输出的optional 属性判断的逻辑

Copy link

paddle-bot bot commented Aug 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoguoguo626807 xiaoguoguo626807 merged commit 1d42b84 into PaddlePaddle:develop Aug 14, 2024
28 checks passed
@xiaoguoguo626807 xiaoguoguo626807 deleted the mix_2 branch August 14, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants