Skip to content

[CINN] Fix bug of infer_symbol_shape of same_operands_result op #66880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Jul 31, 2024

PR Category

CINN

PR Types

Bug fixes

Description

Pcard-67164

  1. 对于输入输出维度相同的op,data区数据不应该被传递,本PR对此问题进行了修复。
  2. 优化符号推导检查逻辑,去掉一些op的推导检查,避免模型运行过慢。
  3. 优化DimExpr除法实现,支持常量的整除化简。

Copy link

paddle-bot bot commented Jul 31, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Hongqing-work
Hongqing-work previously approved these changes Jul 31, 2024
if (num % dem == 0) {
return num / dem;
}
return num / dem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SubstituteDimExpr的时候貌似没法进一步化简了,但是感觉应该情况比较少

@zyfncg zyfncg merged commit 3c73c03 into PaddlePaddle:develop Aug 3, 2024
31 checks passed
@zyfncg zyfncg deleted the fix_same_operands_result branch August 3, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants