【Infer Symbolic Shape BUAA No.70】Add lerp op #66837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… develop upstream
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
luotao1
approved these changes
Aug 5, 2024
Comment on lines
+864
to
+874
| if (x_ndims > y_ndims) { | ||
| out1_shape.assign(x_shape.begin(), x_shape.end()); | ||
| } else if (x_ndims < y_ndims) { | ||
| out1_shape.assign(y_shape.begin(), y_shape.end()); | ||
| } else { | ||
| symbol::DimExprBuilder builder; | ||
| for (size_t i = 0; i < x_ndims; ++i) { | ||
| out1_shape.emplace_back(builder.Broadcast(x_shape[i], y_shape[i])); | ||
| infer_context->AddBroadcastableCstr(x_shape[i], y_shape[i]); | ||
| } | ||
| } |
There was a problem hiding this comment.
rank不同也需要使用broadcast后的shape并且添加约束，对应于代码中前两个if的处理
There was a problem hiding this comment.
不好意思，已经merge了，需要revert么
revert比较麻烦，泓清提示的是补充信息，不添加也能跑，我让一洲补充一个pr吧
gongshaotian
added a commit
to gongshaotian/Paddle
that referenced
this pull request
Aug 5, 2024
)" This reverts commit 5914bd9.
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
Add lerp op.
考虑 x，y 和 w 的广播机制，推断出 output形状。