[DCU] fix topp kernel #66630
Merged
[DCU] fix topp kernel #66630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Deleter-D
reviewed
Jul 30, 2024
| @@ -919,8 +919,13 @@ __global__ void topp_sampling_ft(T* sorted_probs, | |||
| } | |||
| } | |||
| if (!skip) { | |||
| #ifdef PADDLE_WITH_CUDA | |||
There was a problem hiding this comment.
我觉得这一部分要调换一下逻辑，用PADDLE_WITH_HIP来判断，和前面语义保持一致会比较好～
|
LGTM |
yuanlehome
approved these changes
Aug 1, 2024
Lans1ot
pushed a commit
to Lans1ot/Paddle
that referenced
this pull request
Aug 5, 2024
* [DCU] fix topp * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Bug fixes
Description
card-85848
fix warp_size and mismatched types in top_p_sampling kernels