[XPU] fix matmul_broadcast_bugs #66485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lj970926
commented
Jul 24, 2024
| @@ -590,7 +592,6 @@ static void MatMulXPUFunction( | |||
| const XPUType* x_data = reinterpret_cast<const XPUType*>(x); | |||
| if (is_x_need_broadcast) { | |||
| XPUType* x_broadcast_data = nullptr; | |||
| xpu::ctx_guard RAII_GUARD(xpu_ctx); | |||
| x_broadcast_data = RAII_GUARD.alloc_l3_or_gm<XPUType>(batch_size * m * k); | |||
There was a problem hiding this comment.
这里在if里创建RAII_GUARD会导致x_broadcast_data在if block退出的时候被释放，后续如果存在多Stream或者FC里申请了临时显存可能踩到。
QingshuChen
approved these changes
Jul 26, 2024
Dale1314
pushed a commit
to Dale1314/Paddle
that referenced
this pull request
Jul 28, 2024
* [XPU] fix matmul_broadcast_bugs * fix more bugs
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Aug 5, 2024
* [XPU] fix matmul_broadcast_bugs * fix more bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Bug fixes
Description