[CINN]Apply broadcast device lowering for too many broadcast tree bugs #66207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Hongqing-work
commented
Jul 19, 2024
Comment on lines
+488
to
+495
| std::optional<std::shared_ptr<BroadcastTree>> GetBroadcastTreeForOptimize( | ||
| const OpLoweringGroupPtr& group) { | ||
| if (!FLAGS_cinn_bc_branch_optimize) return std::nullopt; | ||
|
|
||
| const common::BroadcastLeaf leaves = [&]() { | ||
| // NOTE(dev): Need UpdateShapeOrDataExprs firstly and the logic | ||
| // will be migated into BucketLower later. | ||
| UpdateGroupShapeOrDataExprs(const_cast<OpLoweringGroupPtr&>(group)); |
There was a problem hiding this comment.
TODO: broadcast tree完全接入之后此函数将仅用于pre_compiler判断，将不需要const_cast，这里只生效保底机制故将原来逻辑直接迁移至此保留const_cast
zyfncg
approved these changes
Jul 19, 2024
tc20042008
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
Pcard-67164
This PR applys broadcast device lowering for too many broadcast tree bugs.