Skip to content

Clean platform/place.h [fluid_ops] #66160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 24, 2024
Merged

Clean platform/place.h [fluid_ops] #66160

merged 7 commits into from
Jul 24, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 18, 2024 •
edited
Loading

PR Category

Others

PR Types

Others

Description

不使用 paddle/fluid/platform/place.h，改为使用 paddle/phi/common/place.h
清理CMakeLists.txt中place依赖

本PR有一定风险，相近的PR不要使用头文件 paddle/fluid/platform/place.h

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jul 18, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 18, 2024
@co63oc co63oc closed this Jul 18, 2024
@co63oc co63oc reopened this Jul 18, 2024
@co63oc co63oc closed this Jul 19, 2024
@co63oc co63oc reopened this Jul 19, 2024
@co63oc co63oc changed the title CI测试不review place [fluid_ops] Clean platform/place.h [fluid_ops] Jul 20, 2024
@co63oc co63oc mentioned this pull request Jul 21, 2024
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 22, 2024
wanghuancoder
wanghuancoder approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ForFishes
ForFishes approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 1744031 into PaddlePaddle:develop Jul 24, 2024
31 checks passed
@co63oc co63oc deleted the fix_place41 branch July 25, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@ForFishes ForFishes ForFishes approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@XiaoguangHu01 XiaoguangHu01 Awaiting requested review from XiaoguangHu01 XiaoguangHu01 is a code owner

@Xreki Xreki Awaiting requested review from Xreki Xreki is a code owner

@qili93 qili93 Awaiting requested review from qili93

@sneaxiy sneaxiy Awaiting requested review from sneaxiy sneaxiy is a code owner

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@co63oc @zhiqiu @Aurelius84 @ForFishes @wanghuancoder @luotao1